Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.10] rancher-logging 105.2.1-rc.1+up4.10.0 update #5115

Open
wants to merge 4 commits into
base: dev-v2.10
Choose a base branch
from

Conversation

jmeza-xyz
Copy link
Contributor

@jmeza-xyz jmeza-xyz commented Feb 7, 2025

Checkpoints for Chart Bumps

release.yaml:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch or minor version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Chart.yaml and index.yaml:

  • The index.yaml file has an entry for your new chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

Fill the following only if required by your manager.

Issue:

rancher/rancher#49048 && SURE-9662

Solution

Added priorityClassName to DS resources for k3s/rke/rk2 only if value is populated in values.yaml

      {{- with .Values.priorityClassName }}
      priorityClassName: {{ . }}
      {{- end }}

Added podPriorityClassName in Logging/FluentBitAgent generic templates with the option to set it in the global or fluentd/fluentbit keys.

    {{- with (default .Values.priorityClassName .Values.fluentd.podPriorityClassName) }}
    podPriorityClassName: {{ . }}
    {{- end }}

    {{- with (default .Values.priorityClassName .Values.fluentd.podPriorityClassName) }}
    podPriorityClassName: {{ . }}
    {{- end }}
# values.yaml addition

fluentbit:
  podPriorityClassName: ""
fluentd:
  podPriorityClassName: ""

QA Testing Considerations

Example values.yaml used for testing. Comment out the podPriorityClassName to test priorityClassName: global-level-test is passed down to all resources.

additionalLoggingSources:
  rke2:
    enabled: true
debug: true
fluentbit:
  podPriorityClassName: resource-level-test
  resources:
    limits:
      memory: 512Mi
    requests:
      cpu: 20m
      memory: 512Mi
fluentd:
  replicas: 1
  podPriorityClassName: resource-level-test
  resources:
    limits:
      memory: 512Mi
    requests:
      cpu: 20m
      memory: 512Mi
priorityClassName: global-level-test
global:
  seLinux:
    enabled: true

Signed-off-by: Meza <meza-xyz@proton.me>
@jmeza-xyz jmeza-xyz requested a review from a team as a code owner February 7, 2025 22:58
Copy link

github-actions bot commented Feb 7, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

github-actions bot commented Feb 7, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck
Copy link
Member

Hey @jmeza-xyz - sorry for the extra headache here, but our team has just migrated logging charts primary source from this repo into https://github.com/rancher/ob-team-charts. As such it would be best if you create a PR in that repo for logging chart and then our team (O&B) can more easily incorporate this fix into the next release we sync into rancher/charts.

Note that this is still early into the migration and that while we migrated the source - and @adamkpickering fixed a bug in the process, we still haven't created the PR to make this the effective source rancher/charts is pulling from. So if can PR this there quickly we can work that into the March release otherwise it might miss and hit in April.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants